Re: Split xlog.c - Mailing list pgsql-hackers

After applying 0001 and 0002 I got a bunch of compile problems:

In file included from /pgsql/source/master/src/include/postgres.h:46,
                 from /pgsql/source/master/src/backend/access/transam/xlog.c:39:
/pgsql/source/master/src/backend/access/transam/xlog.c: In function 'StartupXLOG':
/pgsql/source/master/src/backend/access/transam/xlog.c:5310:10: error: 'lastPageBeginPtr' undeclared (first use in this
function)
   Assert(lastPageBeginPtr == EndOfLog);
          ^~~~~~~~~~~~~~~~
/pgsql/source/master/src/include/c.h:848:9: note: in definition of macro 'Assert'
   if (!(condition)) \
         ^~~~~~~~~
/pgsql/source/master/src/backend/access/transam/xlog.c:5310:10: note: each undeclared identifier is reported only once
foreach function it appears in
 
   Assert(lastPageBeginPtr == EndOfLog);
          ^~~~~~~~~~~~~~~~
/pgsql/source/master/src/include/c.h:848:9: note: in definition of macro 'Assert'
   if (!(condition)) \
         ^~~~~~~~~
make[4]: *** [../../../../src/Makefile.global:938: xlog.o] Error 1
/pgsql/source/master/src/backend/access/transam/xlog.c:5310:10: error: use of undeclared identifier 'lastPageBeginPtr'
                Assert(lastPageBeginPtr == EndOfLog);
                       ^
1 error generated.
make[4]: *** [../../../../src/Makefile.global:1070: xlog.bc] Error 1
make[4]: Target 'all' not remade because of errors.
make[3]: *** [/pgsql/source/master/src/backend/common.mk:39: transam-recursive] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [/pgsql/source/master/src/backend/common.mk:39: access-recursive] Error 2
make[2]: Target 'install' not remade because of errors.
make[1]: *** [Makefile:42: install-backend-recurse] Error 2
make[1]: Target 'install' not remade because of errors.
make: *** [GNUmakefile:11: install-src-recurse] Error 2
make: Target 'install' not remade because of errors.
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c: In function 'apw_load_buffers':
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c:301:9: warning: implicit declaration of function 'AllocateFile';
didyou mean 'load_file'? [-Wimplicit-function-declaration]
 
  file = AllocateFile(AUTOPREWARM_FILE, "r");
         ^~~~~~~~~~~~
         load_file
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c:301:7: warning: assignment to 'FILE *' {aka 'struct _IO_FILE *'}
from'int' makes pointer from integer without a cast [-Wint-conversion]
 
  file = AllocateFile(AUTOPREWARM_FILE, "r");
       ^
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c:342:2: warning: implicit declaration of function 'FreeFile'
[-Wimplicit-function-declaration]
  FreeFile(file);
  ^~~~~~~~
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c: In function 'apw_dump_now':
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c:630:7: warning: assignment to 'FILE *' {aka 'struct _IO_FILE *'}
from'int' makes pointer from integer without a cast [-Wint-conversion]
 
  file = AllocateFile(transient_dump_file_path, "w");
       ^
/pgsql/source/master/contrib/pg_prewarm/autoprewarm.c:694:9: warning: implicit declaration of function
'durable_rename';did you mean 'errtablecolname'? [-Wimplicit-function-declaration]
 
  (void) durable_rename(transient_dump_file_path, AUTOPREWARM_FILE, ERROR);
         ^~~~~~~~~~~~~~
         errtablecolname



-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/