Re: Have I found an interval arithmetic bug? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Have I found an interval arithmetic bug?
Date
Msg-id 20210730160854.GA9600@momjian.us
Whole thread Raw
In response to Re: Have I found an interval arithmetic bug?  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Have I found an interval arithmetic bug?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jul 30, 2021 at 12:04:39PM -0400, Bruce Momjian wrote:
> On Wed, Jul 28, 2021 at 11:19:16AM -0400, Bruce Momjian wrote:
> > On Wed, Jul 28, 2021 at 08:42:31AM +0100, Dean Rasheed wrote:
> > > So it's equal even without calling justify_interval() on the result.
> > > 
> > > FWIW, I remain of the opinion that the interval literal code should
> > > just spill down to lower units in all cases, just like the
> > > multiplication and division code, so that the results are consistent
> > > (barring floating point rounding errors) and explainable.
> > 
> > Here is a more minimal patch that doesn't change the spill-down units at
> > all, but merely documents it, and changes the spilldown to months to
> > round instead of truncate.
> 
> Unless I hear more feedback, I plan to apply this doc patch to all
> branches with the word "rounded" changed to "truncated" in the back
> branches, and apply the rounded code changes to master.

Now that I think of it, I will just remove the word "rounded" from the
back branch docs so we are technically breaking the documented API less
in PG 15.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.




pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Have I found an interval arithmetic bug?
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Slightly improve initdb --sync-only option's help message