Re: window build doesn't apply PG_CPPFLAGS correctly - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: window build doesn't apply PG_CPPFLAGS correctly
Date
Msg-id 202107221341.r6na3ijiaml6@alvherre.pgsql
Whole thread Raw
In response to Re: window build doesn't apply PG_CPPFLAGS correctly  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: window build doesn't apply PG_CPPFLAGS correctly  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 2021-Jul-22, Pavel Stehule wrote:

> čt 22. 7. 2021 v 14:04 odesílatel Andrew Dunstan <andrew@dunslane.net>
> napsal:

> > Almost everything in the Makefiles is not used by the MSVC buid system.
> > Using this one seems likely to be quite difficult, since the syntax for
> > the MSVC compiler command line is very different, and furthermore the
> > MSVC build system doesn't know anything about how to use this setting.
> >
> > AFAICT PG_CPPFLAGS is only used by pgxs.
> >
> > You would need to tell us more about how your build process is working.
> 
> I need access to plpgsql.h in build time. This is only one dependency. When
> I build an extension, then plpgsql.h is in a shared directory. But when I
> build a module for a test, the header files are not installed yet. For
> build it requires an include dir -I$(top_srcdir)/src/pl/plpgsql/src

But Project.pm parses Makefiles and puts stuff into the MSVC buildsystem
file format; note David Rowley's patch that (among other things) removes
a bunch of ->AddIncludeDir calls by parsing PG_CPPFLAGS
https://postgr.es/m/CAApHDvpXoav0aZnsji-ZNdo=9TXqAwnwmSh44gyn8K7i2PRwJg@mail.gmail.com
which is probably apropos.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"I must say, I am absolutely impressed with what pgsql's implementation of
VALUES allows me to do. It's kind of ridiculous how much "work" goes away in
my code.  Too bad I can't do this at work (Oracle 8/9)."       (Tom Allison)
           http://archives.postgresql.org/pgsql-general/2007-06/msg00016.php



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Detecting File Damage & Inconsistencies
Next
From: John Naylor
Date:
Subject: Re: Use quick select instead of qsort to get median