Re: Race condition in InvalidateObsoleteReplicationSlots() - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Race condition in InvalidateObsoleteReplicationSlots()
Date
Msg-id 202107051700.ufepxx37udrt@alvherre.pgsql
Whole thread Raw
In response to Re: Race condition in InvalidateObsoleteReplicationSlots()  (vignesh C <vignesh21@gmail.com>)
Responses Re: Race condition in InvalidateObsoleteReplicationSlots()  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On 2021-Jul-05, vignesh C wrote:

> On Wed, Jun 23, 2021 at 7:32 PM Álvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> >
> > On 2021-Jun-20, Tom Lane wrote:
> >
> > > Actually ... isn't there a second race, in the opposite direction?
> > > IIUC, the point of this is that once we force some WAL to be sent
> > > to the frozen sender/receiver, they'll be killed for failure to
> > > respond.  But the advance_wal call is not the only possible cause
> > > of that; a background autovacuum for example could emit some WAL.
> > > So I fear it's possible for the 'to release replication slot'
> > > message to come out before we capture $logstart.  I think you
> > > need to capture that value before the kill not after.
> >
> > I accounted for all those things and pushed again.
> 
> I saw that this patch is pushed. If there is no pending work left for
> this, can we change the commitfest entry to Committed.

There is none that I'm aware of, please mark it committed.  Thanks

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: simplifying foreign key/RI checks
Next
From: Justin Pryzby
Date:
Subject: Re: Removed extra memory allocations from create_list_bounds