Re: Maintaining a list of pgindent commits for "git blame" to ignore - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Maintaining a list of pgindent commits for "git blame" to ignore
Date
Msg-id 202106230000.4cfnjbp25o3k@alvherre.pgsql
Whole thread Raw
In response to Re: Maintaining a list of pgindent commits for "git blame" to ignore  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Maintaining a list of pgindent commits for "git blame" to ignore
List pgsql-hackers
On 2021-Mar-18, Peter Geoghegan wrote:

> On Thu, Mar 18, 2021 at 3:12 PM Bruce Momjian <bruce@momjian.us> wrote:
> > It would be kind of nice if the file can be generated automatically.  I
> > have you checked if 'pgindent' being on the first line of the commit is
> > sufficient?
> 
> I generated the file by looking for commits that:
> 
> 1) Mentioned "pgindent" or "PGINDENT" in the entire commit message.
> 
> 2) Had more than 20 or 30 files changed.

Is there a minimum git version for this to work?  It doesn't seem to
work for me.

... ah, apparently one needs git 2.23:
https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame

I have 2.20.

[ apt install -t buster-backports git ]

I have 2.30.  It works better.  To be clear: some lines still appear as
originating in some pgindent commit, when they are created by such a
commit.  But as far as I've seen, they're mostly uninteresting ones
(whitespace, only braces, only "else", only "for (;;)" and similar).
   
The git blame experience seems much better.  Thanks!

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Next
From: Peter Geoghegan
Date:
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore