Re: Move pg_attribute.attcompression to earlier in struct for reduced size? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date
Msg-id 202106042321.6jx54yliy2l6@alvherre.pgsql
Whole thread Raw
In response to Re: Move pg_attribute.attcompression to earlier in struct for reduced size?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
List pgsql-hackers
On 2021-Jun-04, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> > Now, while this patch does seem to work correctly, it raises a number of
> > weird cpluspluscheck warnings, which I think are attributable to the
> > new macro definitions.  I didn't look into it closely, but I suppose it
> > should be fixable given sufficient effort:
> 
> Didn't test, but the first one is certainly fixable by adding a cast,
> and I guess the others might be as well.

I get no warnings with this one.  I'm a bit wary of leaving
VARDATA_COMPRESSED_GET_EXTSIZE unchanged, but at least nothing in this
patch requires a cast there.

-- 
Álvaro Herrera       Valdivia, Chile

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Table AM modifications to accept column projection lists
Next
From: Tom Lane
Date:
Subject: Re: join pushdown and issue with foreign update