Re: compute_query_id and pg_stat_statements - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: compute_query_id and pg_stat_statements
Date
Msg-id 20210515230125.GA2951@alvherre.pgsql
Whole thread Raw
In response to Re: compute_query_id and pg_stat_statements  (Bruce Momjian <bruce@momjian.us>)
Responses Re: compute_query_id and pg_stat_statements
List pgsql-hackers
On 2021-May-15, Bruce Momjian wrote:

> On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:

> > I wonder why the initial line says "query hash" instead of "query
> > identifier".  Do we want to say "hash" everywhere?  Why didn't we name
> > the GUC "compute_query_hash" in that case?
> 
> It is queryid (no underscore) in pg_stat_statements, which was a whole
> different discussion.  ;-)

Yeah, I realize that, but I wonder if we shouldn't use the term "query
identifier" instead of "query hash" in that paragraph.

> I also added Alvaro as an author of the compute_query_id item.

I've been wondering if I should ask to stick my name in other features I
helped get committed -- specifically the PQtrace() item and autovacuum
for partitioned tables.  I'll go comment in the release notes thread.

-- 
Álvaro Herrera       Valdivia, Chile
"Digital and video cameras have this adjustment and film cameras don't for the
same reason dogs and cats lick themselves: because they can."   (Ken Rockwell)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: prion failed with ERROR: missing chunk number 0 for toast value 14334 in pg_toast_2619
Next
From: Alvaro Herrera
Date:
Subject: Re: PG 14 release notes, first draft