Re: GetSubscriptionRelations declares too many scan keys - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: GetSubscriptionRelations declares too many scan keys
Date
Msg-id 20210510085640.p7y5c7px5mtsi55y@nol
Whole thread Raw
In response to Re: GetSubscriptionRelations declares too many scan keys  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
On Mon, May 10, 2021 at 01:39:31PM +0530, Bharath Rupireddy wrote:
> On Mon, May 10, 2021 at 12:36 PM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > The function GetSubscriptionRelations was declaring ScanKeyData
> > skey[2]; but actually
> > only uses 1 scan key. It seems like the code was cut/paste from other
> > nearby functions
> > which really are using 2 keys.
> >
> > PSA a trivial patch to declare the correct number of keys for this function.
> 
> +1 for the change. It looks like a cut/paste type introduced by the
> commit 7c4f52409a.
> 
> A comment on the patch: why do we need to declare an array of 1
> element ScanKeyData skey[1];? Instead, can we just do ScanKeyData
> skey;?

+1, there are already many places where it's done this way if there's only 1
key.



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: PG 14 release notes, first draft
Next
From: Dilip Kumar
Date:
Subject: Re: Race condition in recovery?