Re: Extending amcheck to check toast size and compression - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Extending amcheck to check toast size and compression
Date
Msg-id 20210504164347.GE27406@telsasoft.com
Whole thread Raw
In response to Extending amcheck to check toast size and compression  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: Extending amcheck to check toast size and compression  (Mark Dilger <mark.dilger@enterprisedb.com>)
List pgsql-hackers
+       /* Oversized toasted attributes should never be stored */
+       if (toast_pointer.va_rawsize > VARLENA_SIZE_LIMIT)
+               report_corruption(ctx,
+                                                 psprintf("toast value %u rawsize %u exceeds limit %u",
+                                                                  toast_pointer.va_valueid,
+                                                                  toast_pointer.va_rawsize,
+                                                                  VARLENA_SIZE_LIMIT));
+

I think the comment sounds wrong since toast is precisely for storage of
"oversized" attributes.

https://www.postgresql.org/docs/current/storage-toast.html
| This section provides an overview of TOAST (The Oversized-Attribute Storage Technique).

-- 
Justin



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: .ready and .done files considered harmful
Next
From: Robert Haas
Date:
Subject: Re: MaxOffsetNumber for Table AMs