On Fri, Apr 16, 2021 at 10:03:42AM -0400, Tom Lane wrote:
>
> Since the proposed patch removes the dependency code's special-case
> handling of the default collation, I don't feel like we need to jump
> through hoops to prove that the default collation is tracked the
> same as other collations. A regression test with alternative outputs
> is a significant ongoing maintenance burden, and I do not see where
> we're getting a commensurate improvement in test coverage. Especially
> since, AFAICS, the two alternative outputs would essentially have to
> accept both the "it works" and "it doesn't work" outcomes.
Fine by me, I was mentioning those if we wanted to keep some extra coverage for
that by I agree it doesn't add much value.
> So I propose that we do 0001 below, which is my first patch plus your
> suggestion about fixing up create_index.sql. This passes check-world
> for me under both C and en_US.utf8 prevailing locales.
That's what I ended up with too, so LGTM!
