Re: shared-memory based stats collector - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: shared-memory based stats collector
Date
Msg-id 20210322.095559.564110342610370315.horikyota.ntt@gmail.com
Whole thread Raw
In response to shared-memory based stats collector  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: shared-memory based stats collector
List pgsql-hackers
At Thu, 18 Mar 2021 01:47:20 -0700, Andres Freund <andres@anarazel.de> wrote in 
> Hi,
> 
> On 2021-03-18 16:56:02 +0900, Kyotaro Horiguchi wrote:
> > At Tue, 16 Mar 2021 10:27:55 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > > At Mon, 15 Mar 2021 17:49:36 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > > > Thanks for committing this!  I'm very happy to see this reduces the
> > > > size of this patchset.
> > > 
> > > Now that 0003 is committed as d75288fb27, and 33394ee6f2 conflicts
> > > with old 0004, I'd like to post a rebased version for future work.
> > > 
> > > The commit 33394ee6f2 adds on-exit forced write of WAL stats on
> > > walwriter and in this patch that part would appear to have been
> > > removed.  However, this patchset already does that by calling to
> > > pgstat_report_stat from pgstat_beshutdown_hook.
> > 
> > Rebased and fixed two bugs.  Not addressed received comments in this
> > version.
> 
> Since I am heavily editing the code, could you submit "functional"
> changes (as opposed to fixing rebase issues) as incremental patches?

Oh.. please wait for.. a moment, maybe.

regareds.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: ikedamsh
Date:
Subject: Re: About to add WAL write/fsync statistics to pg_stat_wal view
Next
From: Michael Paquier
Date:
Subject: PostgreSQL 14 Feature Freeze + Release Management Team (RMT)