Re: 2021-02-11 release announcement draft - Mailing list pgsql-hackers

From Noah Misch
Subject Re: 2021-02-11 release announcement draft
Date
Msg-id 20210208231152.GA523729@rfd.leadboat.com
Whole thread Raw
In response to 2021-02-11 release announcement draft  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Responses Re: 2021-02-11 release announcement draft
List pgsql-hackers
On Mon, Feb 08, 2021 at 05:40:41PM -0500, Jonathan S. Katz wrote:
> This update also fixes over 80 bugs that were reported in the last several
> months. Some of these issues only affect version 13, but may also apply to other
> supported versions.

Did you want s/may/many/?

> * Fix an issue with GiST indexes where concurrent insertions could lead to a
> corrupt index with entries placed in the wrong pages. You should `REINDEX` any
> affected GiST indexes.

For what it's worth, there's little way for a user to confirm whether an index
is affected.  (If you've never had more than one connection changing the table
at a time, the table's indexes would be unaffected.)

> * Fix `CREATE INDEX CONCURRENTLY` to ensure rows from concurrent prepared
> transactions are included in the index.

Consider adding a sentence like "Installations that have enabled prepared
transactions should `REINDEX` any concurrently-built indexes."  The release
notes say:

+      In installations that have enabled prepared transactions
+      (<varname>max_prepared_transactions</varname> > 0),
+      it's recommended to reindex any concurrently-built indexes in
+      case this problem occurred when they were built.

> * Fix a failure when a PL/pgSQL procedure used `CALL` on another procedure that
> has `OUT` parameters did not call execute a `COMMIT` or `ROLLBACK`.

The release notes say the failure happened when the callee _did_ execute a
COMMIT or ROLLBACK:

+     <para>
+      A <command>CALL</command> in a PL/pgSQL procedure, to another
+      procedure that has OUT parameters, would fail if the called
+      procedure did a <command>COMMIT</command>
+      or <command>ROLLBACK</command>.
+     </para>

> For more details, please see the
> [release notes](https://www.postgresql.org/docs/current/release.html).

I recommend pointing this to https://www.postgresql.org/docs/release/, since
the above link now contains only v13 notes.



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Support for NSS as a libpq TLS backend
Next
From: Jacob Champion
Date:
Subject: Re: Proposal: Save user's original authenticated identity for logging