On 2021-Jan-23, Tom Lane wrote:
> Enlarging on that a little: the coverage in src/interfaces/ecpg
> changes from
> 11860/(11860+12555.) = 0.48577
> to
> 11908/(11908+12507.) = 0.48773
Hm, a 0.2% increase ... sounds marginal.
The other two increases are more interesting, but if the code is already
covered by ssl/ldap/kerberos, then the checktcp test isn't buying much there
either.
So the script has this:
make -j12
make -j12 -C contrib
make -j12 -Otarget check-world PG_TEST_EXTRA="ssl ldap kerberos"
make -C src/interfaces/ecpg/test checktcp
make coverage-html
I mentioned in https://postgr.es/m/20190530202311.GA22421@alvherre.pgsql
that ecpg coverage was bad, and that it increased with "checktcp". I
didn't quote exactly what was the change, though :-(
If what this test mode adds is really just a 0.2% increase, then that
doesn't seem worth the risk. I think the only extra test it runs is
connect/test1.
--
Álvaro Herrera Valdivia, Chile
"Ed is the standard text editor."
http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3
