Re: strange error reporting - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: strange error reporting
Date
Msg-id 20210120184446.GA22263@alvherre.pgsql
Whole thread Raw
In response to Re: strange error reporting  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: strange error reporting  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2021-Jan-20, Robert Haas wrote:

> On Wed, Jan 20, 2021 at 1:25 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > That's because pgbench reports the input argument dbname, but since you
> > didn't specify anything, then PQconnectdbParams() uses the libpq
> > behavior.  I think we'd have to use PQdb() instead.
> 
> I figured it was something like that. I don't know whether the right
> thing is to use something like PQdb() to get the correct database
> name, or whether we should go with Tom's suggestion and omit that
> detail altogether, but I think showing the empty string when the user
> relied on the default is too confusing.

Well, the patch seems small enough, and I don't think it'll be in any
way helpful to omit that detail.

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"Having your biases confirmed independently is how scientific progress is
made, and hence made our great society what it is today" (Mary Gardiner)

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: strange error reporting
Next
From: Peter Geoghegan
Date:
Subject: Re: Deleting older versions in unique indexes to avoid page splits