Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix a typo in xlogreader.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Fix a typo in xlogreader.c
Date
Msg-id 20210112150721.GA8344@alvherre.pgsql
Whole thread Raw
In response to Fix a typo in xlogreader.c  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Tree view 
On 2021-Jan-12, Masahiko Sawada wrote:

> Hi,
> 
> The function comment of RestoreBlockImage() seems not correct since it
> returns a boolean, not the buffer number.

You're right -- this has always been wrong.  Pushed your patch.

Thank you!



-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"It takes less than 2 seconds to get to 78% complete; that's a good sign.
A few seconds later it's at 90%, but it seems to have stuck there.  Did
somebody make percentages logarithmic while I wasn't looking?"
                http://smylers.hates-software.com/2005/09/08/1995c749.html

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Executing inet_server_addr/port() in parallel workers
Next
From: Alvaro Herrera
Date:
Subject: Re: O(n^2) system calls in RemoveOldXlogFiles()