Re: pglz compression performance, take two - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: pglz compression performance, take two
Date
Msg-id 20201230043930.GG25152@telsasoft.com
Whole thread Raw
In response to Re: pglz compression performance, take two  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: pglz compression performance, take two
List pgsql-hackers
On Sat, Dec 26, 2020 at 12:06:59PM +0500, Andrey Borodin wrote:
> > 12 дек. 2020 г., в 22:47, Andrey Borodin <x4mmm@yandex-team.ru> написал(а):
> I've cleaned up comments, checked that memory alignment stuff actually make sense for 32-bit ARM (according to
Godbolt)and did some more code cleanup. PFA v2 patch.
 

> 
> I'm still in doubt should I register this patch on CF or not. I'm willing to work on this, but it's not clear will it
hitPGv14. And I hope for PGv15 we will have lz4 or something better for WAL compression.
 

Thanks for registering it.

There's some typos in the current patch;

farer (further: but it's not your typo)
positiion
reduce a => reduce the
monotonicity what => monotonicity, which
lesser good => less good
allign: align

This comment I couldn't understand:
+        * As initial compare for short matches compares 4 bytes then for the end
+        * of stream length of match should be cut

-- 
Justin



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Cache relation sizes?
Next
From: Thomas Munro
Date:
Subject: Re: Cache relation sizes?