Invalidate acl.c caches for pg_authid.rolinherit changes - Mailing list pgsql-hackers

From Noah Misch
Subject Invalidate acl.c caches for pg_authid.rolinherit changes
Date
Msg-id 20201221095028.GB3777719@rfd.leadboat.com
Whole thread Raw
Responses Re: Invalidate acl.c caches for pg_authid.rolinherit changes
List pgsql-hackers
Backends reflect "GRANT role_name" changes rather quickly, due to a syscache
invalidation callback.  Let's register an additional callback to reflect
"ALTER ROLE ... [NO]INHERIT" with equal speed.  I propose to back-patch this.
While pg_authid changes may be more frequent than pg_auth_members changes, I
expect neither is frequent enough to worry about the resulting acl.c cache
miss rate.

pg_authid changes don't affect cached_membership_roles, so I could have
invalidated cached_privs_roles only.  That felt like needless complexity.  I
expect cached_privs_role gets the bulk of traffic, since SELECT, INSERT,
UPDATE and DELETE use it.  cached_membership_roles pertains to DDL and such.

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Single transaction in the tablesync worker?
Next
From: Konstantin Knizhnik
Date:
Subject: Re: On login trigger: take three