Re: Change definitions of bitmap flags to bit-shifting style - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Change definitions of bitmap flags to bit-shifting style
Date
Msg-id 20201206013109.GA25661@alvherre.pgsql
Whole thread Raw
In response to Re: Change definitions of bitmap flags to bit-shifting style  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Change definitions of bitmap flags to bit-shifting style
List pgsql-hackers
On 2020-Dec-05, Tom Lane wrote:

> FWIW, personally I'd vote for doing the exact opposite.  When you are
> debugging and examining the contents of a bitmask variable, it's easier to
> correlate a value like "0x03" with definitions made in the former style.
> Or at least I think so; maybe others see it differently.

The hexadecimal representation is more natural to me than bit-shifting,
so I would prefer to use that style too.  But maybe I'm trained to it
because of looking at t_infomask symbols constantly.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Next
From: Alvaro Herrera
Date:
Subject: Re: A few new options for CHECKPOINT