On Mon, Nov 09, 2020 at 10:48:09PM +0300, Anastasia Lubennikova wrote:
> I see Tom's objection above. Still, I tend to agree that if 'WITH NO DATA'
> was specified explicitly, CREATE AS should behave more like a utility
> statement rather than a regular query. So I think that this patch can be
> useful in some use-cases and I definitely don't see any harm it could cause.
> Even the comment in the current code suggests that it is an option.
I agree with Tom's point to leave this stuff alone, and just remove
this XXX comment. An extra issue I can see is that you would bypass
ExecutorCheckPerms_hook_type when using WITH NO DATA. This could
silently break the users of this hook.
--
Michael
