> Status update for a commitfest entry.
>
> This patch is ReadyForCommitter. It applies and passes the CI. There are no unanswered questions in the discussion.
>
> The discussion started in 2015 with a patch by Jeff Janes. Later it was revived by Pavan Deolasee. After it was
pickedup by Ibrar Ahmed and finally, it was rewritten by me, so I moved myself from reviewers to authors as well.
>
> The latest version was reviewed and tested by Ibrar Ahmed. The patch doesn't affect COPY FREEZE performance and
significantlydecreases the time of the following VACUUM.
I have tested the patch on my laptop (mem 16GB, SSD 512GB) using the
data introduced in up thread and saw that VACCUM after COPY FREEZE is
nearly 60 times faster than current master branch. Quite impressive.
By the way, I noticed following comment:
+ /*
+ * vmbuffer should be already pinned by RelationGetBufferForTuple,
+ * Though, it's fine if is not. all_frozen is just an optimization.
+ */
could be enhanced like below. What do you think?
+ /*
+ * vmbuffer should be already pinned by RelationGetBufferForTuple.
+ * Though, it's fine if it is not. all_frozen is just an optimization.
+ */
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
