Re: Enumize logical replication message actions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Enumize logical replication message actions
Date
Msg-id 20201023013141.GA8393@alvherre.pgsql
Whole thread Raw
In response to Re: Enumize logical replication message actions  (Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>)
Responses Re: Enumize logical replication message actions  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On 2020-Oct-22, Ashutosh Bapat wrote:

> On Thu, 22 Oct 2020 at 14:46, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> wrote:

> > pg_send_logicalrep_msg_type() looks somewhat too-much.  If we need
> > something like that we shouldn't do this refactoring, I think.
> 
> Enum is an integer, and we want to send byte. The function asserts that the
> enum fits a byte. If there's a way to declare byte long enums I would use
> that. But I didn't find a way to do that.

I didn't look at the code, but maybe it's sufficient to add a
StaticAssert?



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Enumize logical replication message actions
Next
From: Andy Fan
Date:
Subject: Would it be helpful for share the patch merge result from cfbot