Re: speed up unicode normalization quick check - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: speed up unicode normalization quick check
Date
Msg-id 20201012062744.GA11617@paquier.xyz
Whole thread Raw
In response to Re: speed up unicode normalization quick check  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: speed up unicode normalization quick check
List pgsql-hackers
On Mon, Oct 12, 2020 at 02:43:06PM +0900, Masahiko Sawada wrote:
> The following warning recently started to be shown in my
> environment(FreeBSD clang 8.0.1). Maybe it is relevant with this
> commit:
>
> unicode_norm.c:478:12: warning: implicit declaration of function
> 'htonl' is invalid in C99 [-Wimplicit-function-declaration]
>         hashkey = htonl(ch);
>                   ^

Thanks, it is of course relevant to this commit.  None of the
BSD animals complain here.  So, while it would be tempting to have an
extra include with arpa/inet.h, I think that it would be better to
just use pg_hton32() in pg_bswap.h, as per the attached.  Does that
take care of your problem?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Amit Kapila
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)