Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add
Date
Msg-id 20201011183513.GA709789@msg.df7cb.de
Whole thread Raw
In response to Re: powerpc pg_atomic_compare_exchange_u32_impl: error: comparison of integer expressions of different signedness (Re: pgsql: For all ppc compilers, implement compare_exchange and) fetch_add  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Re: Tom Lane
> > I plan not to back-patch either of these.
> 
> Hmm, I'd argue for a back-patch.  The issue of modern compilers
> warning about the incorrect code will apply to all supported branches.
> Moreover, even if we don't use these code paths today, who's to say
> that someone won't back-patch a bug fix that requires them?  I do not
> think it's unreasonable to expect these functions to work well in
> all branches that have them.

Or remove them. (But fixing seems better.)

Christoph



pgsql-hackers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: [PATCH] Add `truncate` option to subscription commands
Next
From: David Christensen
Date:
Subject: Re: [PATCH] Add `truncate` option to subscription commands