Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version
Date
Msg-id 20201009234251.GA8419@momjian.us
Whole thread Raw
In response to Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version  (Justin Pryzby <pryzby@telsasoft.com>)
Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tree view 
On Fri, Oct  9, 2020 at 02:23:10PM -0500, Justin Pryzby wrote:
> In my local branch, I had revised this comment to say:
> 
> + * Note, v8.4 has no tablespace_suffix, which is fine so long as the version we
> + * being upgraded *to* has a suffix, since it's not allowed to pg_upgrade from
> + * a version to the same version if tablespaces are in use.

OK, updated patch attached.  Also, from your original patch, I didn't
need to call canonicalize_path() since we are not comparing paths, and I
didn't need to include common/relpath.h.  I also renamed a variable.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)
Next
From: Ranier Vilela
Date:
Subject: Re: Possible NULL dereferencing null pointer (src/backend/executor/nodeIncrementalSort.c)