Re: Add primary keys to system catalogs - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add primary keys to system catalogs
Date
Msg-id 20201006183450.f4jn7vzwsokqwgi2@alap3.anarazel.de
Whole thread Raw
In response to Add primary keys to system catalogs  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Add primary keys to system catalogs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2020-10-03 08:40:31 +0200, Peter Eisentraut wrote:
> Since we have ADD PRIMARY KEY USING INDEX, we can declare a primary key for
> an existing index.  So this doesn't have to affect the low-level early
> bootstrapping.  The attached patch adds those commands manually. Another
> option might be to have the catalog generation Perl tooling create those
> declarations automatically from some marker in the catalog files.  That
> would also allow declaring unique constraints for the unique indexes that
> don't end up being the primary key.

Hm. What prevents us from declaring the pkey during bootstrap? I don't
at all like adding yet another place that needs manual editing when
doing DDL changes.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: A modest proposal: let's add PID to assertion failure messages
Next
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade dead code for pre-8.4 versions