On Wed, Sep 2, 2020 at 03:47:40PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I used a later version of Tom's patch to add documentation of how
> > connection strings can override command-line options, plus it has the
> > password description improvements.
>
> > <option>--all</option>) is not used, the database name is read
> > from the environment variable <envar>PGDATABASE</envar>. If
> > that is not set, the user name specified for the connection is
> > - used.
> > + used. <link linkend="libpq-connstring">Connction strings</link>
> > + can also be used for connection specifications, and these can
> > + override other command-line options.
> > </para>
> > </listitem>
> > </varlistentry>
>
> * Spellcheck (not "Connction" please)
>
> * I do not like the wording "can override", because that's just impossibly
> vague. It leaves the reader wondering whether there are cases where that
> doesn't happen.
>
> I'd suggest wording more like
>
> The <replaceable>dbname</replaceable> can be a
> <link ...>connection string</link>. If so, connection parameters
> found in the connection string will override any conflicting command
> line options, such as <option>--username</option>.
Sure, makes sense. Updated patch attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
