Re: Switch to multi-inserts for pg_depend - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Switch to multi-inserts for pg_depend
Date
Msg-id 20200813044045.GF11663@paquier.xyz
Whole thread Raw
In response to Re: Switch to multi-inserts for pg_depend  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Switch to multi-inserts for pg_depend  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Aug 12, 2020 at 07:52:42PM -0400, Alvaro Herrera wrote:
> Yeah.  As I understand, the only reason to have this number is to avoid
> an arbitrarily large number of entries created as a single multi-insert
> WAL record ... but does that really ever happen?  I guess if you create
> a table with some really complicated schema you might get, say, a
> hundred pg_depend rows at once.  But to fill eight complete pages of
> pg_depend entries sounds astoundingly ridiculous already -- I'd say it's
> just an easy way to spell "infinity" for this.  Tweaking one infinity
> value to become some other infinity value sounds useless.
>
> So I agree with what Andres said.  Let's have just one such define and
> be done with it.

Okay.  Would src/include/catalog/catalog.h be a suited location for
this flag or somebody has a better idea?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: REINDEX SCHEMA/DATABASE/SYSTEM weak with dropped relations
Next
From: Thomas Munro
Date:
Subject: Re: Parallel query hangs after a smart shutdown is issued