Re: [bugfix]"make installcheck" could not work in PGXS - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [bugfix]"make installcheck" could not work in PGXS
Date
Msg-id 20200731105756.GF3317@paquier.xyz
Whole thread Raw
In response to [bugfix]"make installcheck" could not work in PGXS  ("matsumura.ryo@fujitsu.com" <matsumura.ryo@fujitsu.com>)
Responses RE: [bugfix]"make installcheck" could not work in PGXS  ("matsumura.ryo@fujitsu.com" <matsumura.ryo@fujitsu.com>)
List pgsql-hackers
On Fri, Jul 31, 2020 at 08:31:56AM +0000, matsumura.ryo@fujitsu.com wrote:
> I found that "make installcheck" could not work in PGXS.

Yeah, that's a known problem.  One way to counter that is for example
to grab the path of pg_regress from pg_config --libdir and set
$ENV{PG_REGRESS} to it, but that's hacky.  So I agree that it would be
good to do something.

> In non-PGXS environment, top_builddir is a relative path against the top of postgresql source tree.
> But, in PGXS, top_builddir is a absolute path like /installdir/lib/pgxs/src/makefiles intentionally.
> The existing code of [Makefile.global.in] does not consider it.
>
> I make a patch.  (It may not to be smart.)
> Please your comments.

Not sure that this goes completely to the right direction.  It seems
to me that we should have room to set and use PG_REGRESS also for
pg_regress_check and pg_regress_installcheck.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Next
From: Robert Haas
Date:
Subject: Re: new heapcheck contrib module