Re: TAP tests and symlinks on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP tests and symlinks on Windows
Date
Msg-id 20200716102028.GE8389@paquier.xyz
Whole thread Raw
In response to Re: TAP tests and symlinks on Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: TAP tests and symlinks on Windows
List pgsql-hackers
On Wed, Jul 15, 2020 at 11:04:28AM -0400, Andrew Dunstan wrote:
> This is the simplest invocation I found to be reliable on msys2 (and it
> took me a long time to find). If you have a tested alternative please
> let me know.

Having a working MSYS environment is still on my TODO list :)

> I don't understand this comment. The skip statement here is in a SKIP
> block. In fact skip only works inside SKIP blocks. (perldoc Test::More
> for details). Maybe you got confused by the diff format.

Indeed, I got trapped by the diff here.  Thanks.

The patch looks good to me.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Encoding of src/timezone/tznames/Europe.txt
Next
From: Masahiko Sawada
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication