Re: Log the location field before any backtrace - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Log the location field before any backtrace
Date
Msg-id 20200710020324.GI11153@paquier.xyz
Whole thread Raw
In response to Re: Log the location field before any backtrace  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Log the location field before any backtrace
List pgsql-hackers
On Thu, Jul 09, 2020 at 12:31:38PM -0400, Alvaro Herrera wrote:
> On 2020-Jul-09, Daniel Gustafsson wrote:
>> On 9 Jul 2020, at 11:17, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>
>>> In PG13, we added the ability to add backtraces to the log
>>> output. After some practical experience with it, I think the
>>> order in which the BACKTRACE and the LOCATION fields are printed
>>> is wrong.  I propose we put the LOCATION field before the
>>> BACKTRACE field, not after.  This makes more sense because the
>>> location is effectively at the lowest level of the backtrace.
>>
>> Makes sense, +1
>
> Likewise

+1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: "kato-sho@fujitsu.com"
Date:
Subject: RE: Performing partition pruning using row value