On 2020-Jul-06, Michael Paquier wrote:
> While refreshing my mind with this code, I got surprised with the
> choice of "routine" in getProcedureTypeDescription() when we need a
> default object type name for an object not found, so I have switched
> that to "procedure" to be more consistent.
I think "routine" was more correct. We introduced that terminology to
encompass both functions and procedures, back when real procedures were
added. See the definitions in the glossary for example.
> I have also spent some time analyzing the coverage of the patch, and
> did not find any obvious holes or any remaining missing_ok paths not
> covered. Some comments were also a bit weird after re-reading them,
> so I tweaked a couple of places.
Cool.
> Attached is for now a rebased patch. If there are any comments,
> please feel free. Daniel, Alvaro, does that look fine for you? I am
> letting this stuff aside for a couple of days for the moment.
I'm not sure that I'll have time to review this in the next couple of
days, but it seemed sufficiently good when I last looked.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
