Postgres Pro
Downloads
Home   >   mailing lists

Missing some ifndef FRONTEND at the top of logging.c and file_utils.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Missing some ifndef FRONTEND at the top of logging.c and file_utils.c
Date
Msg-id 20200625080757.GI130132@paquier.xyz
Whole thread Raw
Responses Re: Missing some ifndef FRONTEND at the top of logging.c andfile_utils.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
Hi all,

As subject tells, we have in src/common/ four files that are only
compiled as part of the frontend: fe_memutils.c, file_utils.c,
logging.c and restricted_token.c.  Two of them are missing the
following, to make sure that we never try to compile them with the
backend:
+#ifndef FRONTEND
+#error "This file is not expected to be compiled for backend code"
+#endif

So, shouldn't that stuff be added as per the attached?

Thanks.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/dependinsertions?
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Review for GetWALAvailability()