Re: TAP tests and symlinks on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP tests and symlinks on Windows
Date
Msg-id 20200623105527.GA1974@paquier.xyz
Whole thread Raw
In response to Re: TAP tests and symlinks on Windows  (Michael Paquier <michael@paquier.xyz>)
Responses Re: TAP tests and symlinks on Windows  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Wed, Jun 17, 2020 at 04:44:34PM +0900, Michael Paquier wrote:
> Okay.  This could be a problem as jacana is proving to have good
> coverage AFAIK.  So it looks like we are really heading in the
> direction is still skipping the test if there is no support for
> symlink in the environment. At least that makes less diffs in the
> patch.

I have implemented a patch based on the feedback received that does
the following, tested with all three patterns (MSVC only on Windows):
- Assume that all non-Windows platform have a proper symlink
implementation for perl.
- If on Windows, check for the presence of Win32::Symlink:
-- If the module is not detected, skip the tests not supported.
-- If the module is detected, run them.

I have added this patch to the next commit fest:
https://commitfest.postgresql.org/28/2612/

Thanks,
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Ranier Vilela
Date:
Subject: Re: Parallel Seq Scan vs kernel read ahead