On 2020-Jun-19, David Rowley wrote:
> > + size = offsetof(SharedAggInfo, sinstrument)
> > + + pcxt->nworkers * sizeof(AggregateInstrumentation);
> >
> > => There's a couple places where I'd prefer to see "+" at the end of the
> > preceding line (but YMMV).
>
> I pretty much just copied the whole of that code from nodeSort.c. I'm
> more inclined to just keep it as similar to that as possible. However,
> if pgindent decides otherwise, then I'll go with that. I imagine it
> won't move it though as that code has already been through indentation
> a few times before.
pgindent won't change your choice here. This seems an ideological
issue; each committer has got their style. Some people prefer to put
operators at the end of the line, others do it this way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
