Re: create database with template doesn't copy database ACL - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: create database with template doesn't copy database ACL
Date
Msg-id 20200615033934.GB12121@momjian.us
Whole thread Raw
In response to Re: create database with template doesn't copy database ACL  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: create database with template doesn't copy database ACL
List pgsql-hackers
On Sun, Jun 14, 2020 at 11:24:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I am unclear if we should be copying the CONNECT and TEMPORARY
> > attributes or documenting that CREATE DATABASE does not copy them.
> 
> We should absolutely not copy them.
> 
> As an example, it'd make sense for an admin to revoke CONNECT on a
> template database, just to help ensure that nobody modifies it.
> If that propagated to every created database, it would be a complete
> fail.
> 
> Moreover, since the ACLs of an object depend quite a bit on who the owner
> is, it'd make no sense to copy them to a new object that has a different
> owner.  The granted-by fields would be wrong, if nothing else.
> 
> In practice, CREATE DATABASE never has copied any database-level property
> of the template DB, only its contents.  (Well, I guess it copies encoding
> and collation by default, but those are descriptive of the contents.)

Well, I thought we copied everything except things tha can be specified
as different in CREATE DATABASE, though I can see why we would not copy
them.  Should we document this or issue a notice about not copying
non-default database attributes?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: create database with template doesn't copy database ACL
Next
From: Fujii Masao
Date:
Subject: min_safe_lsn column in pg_replication_slots view