Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c)
Date
Msg-id 20200611201921.GA29675@alvherre.pgsql
Whole thread Raw
In response to [PATCH] fix two shadow vars (src/backend/commands/sequence.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: [PATCH] fix two shadow vars (src/backend/commands/sequence.c)
List pgsql-hackers
Tree view 
On 2020-Jun-11, Ranier Vilela wrote:

> Hi,
> src/backend/commands/sequence.c
> Has two shadows (buf var), with two unnecessary variables declared.

These are not unnecessary -- removing them breaks translatability of
those messages.  If these were ssize_t you could use '%zd' (see commit
ac4ef637ad2f) but I don't think you can in this case.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Atomic operations within spinlocks
Next
From: Jeff Davis
Date:
Subject: Re: Default setting for enable_hashagg_disk