Re: Removal of currtid()/currtid2() and some table AM cleanup - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Removal of currtid()/currtid2() and some table AM cleanup
Date
Msg-id 20200604175905.mkveizxp3fn7bhyr@alap3.anarazel.de
Whole thread Raw
In response to Removal of currtid()/currtid2() and some table AM cleanup  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Removal of currtid()/currtid2() and some table AM cleanup  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

On 2020-06-03 11:14:48 +0900, Michael Paquier wrote:
> I would like to remove those two functions and the surrounding code
> for v14, leading to some cleanup:
>  6 files changed, 326 deletions(-)

+1


> While on it, I have noticed that heap_get_latest_tid() is still
> located within heapam.c, but we can just move it within
> heapam_handler.c.

What's the point of that change? I think the differentiation between
heapam_handler.c and heapam.c could be clearer, but if anything, I'd
argue that heap_get_latest_tid is sufficiently low-level that it'd
belong in heapam.c.


Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Atomic operations within spinlocks
Next
From: Rajin Raj
Date:
Subject: Re: Regarding TZ conversion