Re: elog(DEBUG2 in SpinLocked section. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: elog(DEBUG2 in SpinLocked section.
Date
Msg-id 20200603054748.GI89559@paquier.xyz
Whole thread Raw
In response to Re: elog(DEBUG2 in SpinLocked section.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: elog(DEBUG2 in SpinLocked section.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jun 03, 2020 at 01:27:51AM -0400, Tom Lane wrote:
> I'm inclined to think that memcpy'ing the ReplicationSlot struct
> into a local variable might be the best way, replacing all the
> piecemeal copying these stanzas are doing right now.  memcpy() of
> a fixed amount of data isn't quite straight-line code perhaps,
> but it has a well-defined runtime and zero chance of throwing an
> error, which are the two properties we should be most urgently
> concerned about.

+1.  And I guess that you are already on that?  ;)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: elog(DEBUG2 in SpinLocked section.
Next
From: Amit Kapila
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2