Re: elog(DEBUG2 in SpinLocked section. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: elog(DEBUG2 in SpinLocked section.
Date
Msg-id 20200603030510.GD89559@paquier.xyz
Whole thread Raw
In response to Re: elog(DEBUG2 in SpinLocked section.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: elog(DEBUG2 in SpinLocked section.  (Amit Kapila <amit.kapila16@gmail.com>)
Re: elog(DEBUG2 in SpinLocked section.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jun 03, 2020 at 09:18:19AM +0900, Kyotaro Horiguchi wrote:
> Thanks to all!

Indeed, this was incorrect.  And you may not have noticed, but we have
a second instance of that in LogicalIncreaseRestartDecodingForSlot()
that goes down to 9.4 and b89e151.  I used a dirty-still-efficient
hack to detect that, and that's the only instance I have spotted.

I am not sure if that's worth worrying a back-patch, but we should
really address that at least on HEAD.  Attached is an extra patch to
close the loop.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Removal of currtid()/currtid2() and some table AM cleanup
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Should we remove a fallback promotion? take 2