Re: hash join error improvement (old) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: hash join error improvement (old)
Date
Msg-id 20200526191710.GA19482@alvherre.pgsql
Whole thread Raw
In response to Re: hash join error improvement (old)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-May-26, Tom Lane wrote:

> Digging further down, it looks like BufFileWrite calls BufFileDumpBuffer
> which calls FileWrite which takes pains to set errno correctly after a
> short write --- so other than the lack of commentary about these
> functions' error-reporting API, I don't think there's any actual bug here.

Doh, you're right, this patch is completely broken ... aside from
carelessly writing the wrong "if" test, my unfamiliarity with the stdio
fread/fwrite interface is showing.  I'll look more carefully.

> Are you sure you correctly identified the source of the bogus error
> report?

Nope.  And I wish the bogus error report was all there was to it.  The
actual problem is a server crash.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Trouble with hashagg spill I/O pattern and costing
Next
From: "Bossart, Nathan"
Date:
Subject: Re: race condition when writing pg_control