Re: Warn when parallel restoring a custom dump without data offsets - Mailing list pgsql-hackers

From David Gilman
Subject Re: Warn when parallel restoring a custom dump without data offsets
Date
Msg-id 20200525215526.t7dqywfywxzmlpbu@dar.local
Whole thread Raw
In response to Re: Warn when parallel restoring a custom dump without data offsets  (David Gilman <dgilman@gilslotd.com>)
Responses Re: Warn when parallel restoring a custom dump without data offsets
List pgsql-hackers
The earlier patches weren't applying because I had "git config
diff.noprefix true" set globally and that was messing up the git
format-patch output.

On Mon, May 25, 2020 at 01:54:29PM -0500, David Gilman wrote:
> And I misunderstood how bad it was. I thought it was reading little
> header structs off the disk but it's actually reading the entire table
> (see _skipData). So you're quadratically rereading entire tables and
> thrashing your cache. Oops.

I changed _skipData to fseeko() instead of fread() when possible to cut
down on this thrashing further.

-- 
David Gilman  :DG<
https://gilslotd.com

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: factorial function/phase out postfix operators?
Next
From: Tomas Vondra
Date:
Subject: Re: Trouble with hashagg spill I/O pattern and costing