Re: Should program exit, When close() failed for O_RDONLY mode - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Should program exit, When close() failed for O_RDONLY mode
Date
Msg-id 20200504002007.GD471944@paquier.xyz
Whole thread Raw
In response to Re: Should program exit, When close() failed for O_RDONLY mode  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Sun, May 03, 2020 at 10:18:27AM -0700, Noah Misch wrote:
> I would not say that.  If close() does fail, something is badly wrong in the
> program or the system running it.  Though I opt not to check the return value,
> if one does check it, exiting is a suitable response.

FWIW, it seems to me that we have an argument for copy_fetch.c that it
can be an advantage to know if something wrong is going on
beforehand: let's remember that after running pg_rewind, the target
will be started to replay up to its consistent point.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [REPORT] Static analys warnings
Next
From: Amit Kapila
Date:
Subject: Re: WAL usage calculation patch