Re: Protocol problem with GSSAPI encryption? - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Protocol problem with GSSAPI encryption?
Date
Msg-id 20200502180237.GZ13712@tamriel.snowman.net
Whole thread Raw
In response to Re: Protocol problem with GSSAPI encryption?  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Greetings,

* Stephen Frost (sfrost@snowman.net) wrote:
> * Andrew Gierth (andrew@tao11.riddles.org.uk) wrote:
> > >>>>> "Peter" == Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> >
> >  >> It seems to me that this is a bug in ProcessStartupPacket, which
> >  >> should accept both GSS or SSL negotiation requests on a connection
> >  >> (in either order). Maybe secure_done should be two flags rather than
> >  >> one?
> >
> >  Peter> I have also seen reports of that. I think your analysis is
> >  Peter> correct.
> >
> > I figure something along these lines for the fix. Anyone in a position
> > to test this?
>
> At least at first blush, I tend to agree with your analysis and patch.
>
> I'll see about getting this actually set up and tested in the next week
> or so (and maybe there's some way to also manage to have a regression
> test for it..).

After testing this and playing around with it a bit, I've gone ahead and
pushed it.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: SLRU statistics
Next
From: Stephen Frost
Date:
Subject: Re: Problems with GSS encryption and SSL in libpq in 12~