Re: Why are wait events not reported even though it reads/writes atimeline history file? - Mailing list pgsql-hackers

On Fri, May 01, 2020 at 12:04:56PM +0900, Fujii Masao wrote:
> I applied cosmetic changes to the patch (attached). Barring any objection,
> I will push this patch (also back-patch to v10 where wait-event for timeline
> file was added).

Sorry for arriving late to the party.  I have one tiny comment.

> +        pgstat_report_wait_start(WAIT_EVENT_TIMELINE_HISTORY_READ);
> +        res = fgets(fline, sizeof(fline), fd);
> +        pgstat_report_wait_end();
> +        if (ferror(fd))
> +            ereport(ERROR,
> +                    (errcode_for_file_access(),
> +                     errmsg("could not read file \"%s\": %m", path)));
> +        if (res == NULL)
> +            break;

It seems to me that there is no point to check ferror() if fgets()
does not return NULL, no?
--
Michael