Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Incremental sort (was: PoC: Partial sort) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date
Msg-id 20200407230207.uqrch5zmotgamqbw@development
Whole thread Raw
In response to Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: [PATCH] Incremental sort (was: PoC: Partial sort)
List pgsql-hackers
Tree view 
On Mon, Apr 06, 2020 at 11:25:21PM -0500, Justin Pryzby wrote:
>On Mon, Apr 06, 2020 at 09:57:22PM +0200, Tomas Vondra wrote:
>> I've pushed the fist part of this patch series - I've reorganized it a
>
>I scanned through this again post-commit.  Find attached some suggestions.
>

Thanks. The typo fixes seem clear, except for this bit:

   * If we've set up either of the sort states yet, we need to reset them.
   * We could end them and null out the pointers, but there's no reason to
   * repay the setup cost, and because ???? guard setting up pivot comparator
   * state similarly, doing so might actually cause a leak.

I can't figure out what ???? should be. James, do you recall what this
should be?


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: WAL usage calculation patch
Next
From: Peter Geoghegan
Date:
Subject: Re: Using the rr debugging tool to debug Postgres