Re: BUG #16325: Assert failure on partitioning by int for a textvalue with a collation - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #16325: Assert failure on partitioning by int for a textvalue with a collation
Date
Msg-id 20200407074944.GA6655@paquier.xyz
Whole thread Raw
In response to Re: BUG #16325: Assert failure on partitioning by int for a textvalue with a collation  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: BUG #16325: Assert failure on partitioning by int for a textvalue with a collation
List pgsql-bugs
On Fri, Apr 03, 2020 at 05:29:10PM +0200, Dmitry Dolgov wrote:
> Thanks for the suggestion. It's not strictly related to the fix I guess,
> but of course you're right, and we can indeed improve this part and
> replace the check with an assert.

Thanks for the new version of the patch.  I have been playing a bit
today, and finished with the version attached.  Some comments have
been tweaked, and I have moved the test in the block with the other
invalid cases for consistency, adding an extra test able to trigger a
similar error within the transformation step where a parse context
exists.  It is a bit late now so I cannot push that today, but I'll
do that tomorrow.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #16346: pg_upgrade fails on a trigger with a comment
Next
From: Grigory Smolkin
Date:
Subject: Re: Don't try fetching future segment of a TLI.