Re: [PATCH] Incremental sort (was: PoC: Partial sort) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date
Msg-id 20200406224434.xwkq5cqgo6g2n4gl@development
Whole thread Raw
In response to Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Apr 06, 2020 at 06:34:04PM -0400, Tom Lane wrote:
>Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> On Mon, Apr 06, 2020 at 05:51:43PM -0400, Tom Lane wrote:
>>> Well, it's *less* unhappy.  thorntail is showing that the number of
>>> workers field is not stable; that will need to be masked.
>
>> Yeah, I've already pushed a fix for that. But there seems to be another
>> failure in th explain output. Looking.
>
>I'm kind of unimpressed with that fix, because it guarantees that if
>there's any problem with more than 2 workers, this test will never
>find it.  I think you should do what I said and arrange to replace
>the number-of-workers output with "N".
>

I can do that, but isn't this how every other regression test does it?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Next
From: James Coleman
Date:
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)