Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Incremental sort (was: PoC: Partial sort) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date
Msg-id 20200406211232.35s2gmygrfx3ljrj@development
Whole thread Raw
In response to Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (James Coleman <jtc331@gmail.com>)
Re: [PATCH] Incremental sort (was: PoC: Partial sort)  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Mon, Apr 06, 2020 at 04:54:38PM -0400, Alvaro Herrera wrote:
>On 2020-Apr-06, Tom Lane wrote:
>
>> Locally, things pass without force_parallel_mode, but turning it on
>> produces failures that look similar to rhinoceros's (didn't examine
>> other BF members).
>
>FWIW I looked at the eight failures there were about fifteen minutes ago
>and they were all identical.  I can confirm that, in my laptop, the
>tests work without that GUC, and fail in exactly that way with it.
>

Yes, there's a thinko in show_incremental_sort_info() and it returns too
soon. I'll push a fix in a minute.


thanks

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: where should I stick that backup?
Next
From: David Zhang
Date:
Subject: ERROR: invalid input syntax for type circle