Re: BUG #16330: psql accesses null pointer in connect.c:do_connect - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
Date
Msg-id 20200331072153.GB1549@paquier.xyz
Whole thread Raw
In response to Re: BUG #16330: psql accesses null pointer in connect.c:do_connect  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
List pgsql-bugs
On Mon, Mar 30, 2020 at 12:48:51PM -0300, Alvaro Herrera wrote:
> On 2020-Mar-30, Tom Lane wrote:
>> It looks to me like there's a similar hazard a bit further down
>> (line 3029):
>>
>>         appendConnStrVal(&connstr, PQdb(o_conn));
>>
>> I wonder if we should force reuse_previous to false if there's
>> no o_conn, rather than fixing this stuff piecemeal.
>
> That was my impression too.

Good point.  What do you think about the attached then?
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Amit Langote
Date:
Subject: Re: BUG #16293: postgres segfaults and returns SQLSTATE 08006
Next
From: Amit Langote
Date:
Subject: Re: BUG #16293: postgres segfaults and returns SQLSTATE 08006