Re: Adding missing object access hook invocations - Mailing list pgsql-hackers

On 2020-Mar-16, Mark Dilger wrote:

> Hackers,
> 
> While working on object access hooks, I noticed several locations where I would expect the hook to be invoked, but no
actualinvocation.  I think this just barely qualifies as a bug.  It's debatable because whether it is a bug depends on
theuser's expectations and whether not invoking the hook in these cases is defensible.  Does anybody have any
recollectionof an intentional choice not to invoke in these locations?
 

Hmm, possibly the create-time calls are missing.

I'm surprised about the InvokeObjectDropHook calls though.  Doesn't
deleteOneObject already call that?  If we have more calls elsewhere,
maybe they are redundant.  I think we should only have those for
"shared" objects.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services